chore: code style simplify #6241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6241.surge.sh |
|
if 的不要挪掉哈，这样会让覆盖率看起来很高实际上代码没跑到。箭头函数优化可以留~ |
afc163
reviewed
Jul 12, 2023
src/components/calendar/convert.ts
Outdated
| if (Array.isArray(value)) { | ||
| return value | ||
| } | ||
| if (Array.isArray(value)) return value |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #6241 +/- ##
===========================================
+ Coverage 90.75% 91.03% +0.27%
===========================================
Files 305 305
Lines 6601 6583 -18
Branches 1644 1643 -1
===========================================
+ Hits 5991 5993 +2
+ Misses 562 544 -18
+ Partials 48 46 -2
☔ View full report in Codecov by Sentry. |
1587315093
changed the title
afc163
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
把 if 语法风格统一了一下，只有一行代码的省略了花括号
删了一些时间久的注释属性
简化了一下箭头函数的 return